hansva commented on code in PR #4823:
URL: https://github.com/apache/hop/pull/4823#discussion_r1929710957
##########
plugins/transforms/concatfields/src/main/java/org/apache/hop/pipeline/transforms/concatfields/ConcatFields.java:
##########
@@ -166,13 +167,32 @@ private Object[] concatFields(Object[] inputRowData)
throws HopException {
}
private void concatField(
- StringBuilder targetField, IValueMeta valueMeta, Object valueData,
String nullString)
+ StringBuilder targetField,
+ IValueMeta valueMeta,
+ Object valueData,
+ String nullString,
+ String trimType)
throws HopValueException {
if (valueMeta.isNull(valueData)) {
targetField.append(nullString);
} else {
- targetField.append(valueMeta.getString(valueData));
+ if (trimType != null) {
+ switch (trimType) {
+ case ConcatFieldsMeta.TRIM_TYPE_LEFT:
+
targetField.append(valueMeta.getString(valueData).replaceAll("^\\s+", ""));
+ break;
+ case ConcatFieldsMeta.TRIM_TYPE_RIGHT:
+
targetField.append(valueMeta.getString(valueData).replaceAll("\\s+$", ""));
+ break;
+ case ConcatFieldsMeta.TRIM_TYPE_BOTH:
+ targetField.append(valueMeta.getString(valueData).trim());
+ break;
+ default:
+ targetField.append(valueMeta.getString(valueData));
+ break;
+ }
+ }
Review Comment:
We have a function in Const -> `org.apache.hop.core.Const#trimToType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
