lnykww opened a new pull request, #5435:
URL: https://github.com/apache/hop/pull/5435
**Please** add a meaningful description for your change here
1. When the name variable is null, calling the equals() function may attempt
to compare null values, resulting in a runtime exception.
`
@Override
public boolean equals(Object object) {
if (object == null) {
return false;
}
if (!(object instanceof GraphModel)) {
return false;
}
if (object == this) {
return true;
}
return name.equalsIgnoreCase(((GraphModel) object).getName());
}
`
3. If labels is null, calling getLabels().isEmpty() will throw a
NullPointerException because we're attempting to access methods on a null
object in Neo4JOutputDialog.java.
`
final int fromLabelRows =
(!input.getNodeFromField().getLabels().isEmpty()
? input.getNodeFromField().getLabels().size()
: 10);
`
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks
pass. A more thorough check will be performed on your pull request
automatically.
- [ ] If you have a group of commits related to the same change, please
squash your commits into one and force push your branch using `git rebase -i`.
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
