sramazzina commented on PR #5647: URL: https://github.com/apache/hop/pull/5647#issuecomment-3242683835
The problem is related to the fact that Formula transform always wrote value_type attribute as a code instead of the name of the value type (ex.: 2 instead of String for example). We are checking if this is the case for any other transform that require the value_typoe attribute saved in its metadata set. Because of this, in the Metadata Injection dialog, the user is required to insert for the value_type attribute the value of 2 (the code of the value type) instead of for example of String (the name of the value type) to have the Metadata Injection transform working. That is a bit weird for the user. My fix makes possible for the user to write the name of the value type instead of its code in the Metadata Injection dialog. Fxing this issue this way is not the best option I know. It's a sort of workaround. That should be fixed in the formula transform so that it saves the things in the correct way. But doing this that way breaks everything because risks not to be backward compatible. I can provide a sample, that is the same sample I used for the tests, to show you that "it never worked". I will attach it to the issue. But the important point here is the way we fix it. IMHO, my solution is a good compromise before the next major release where we will fix it the way it should be in the correct way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
