S3tuit commented on issue #5598:
URL: https://github.com/apache/hop/issues/5598#issuecomment-3306833787

   This looks like a locale parsing issue rather than your data. In Portugal 
(similar to IT), numbers use `.` for grouping and `,` for decimals. 
   
   ### Quick workarounds
   
   **In Filter Rows:**
   Either set the constant’s Type to BigNumber, or keep Type = Number and set 
the Decimal symbol to `,` (then write 0,0, 10,5, etc.).
   
   **In Select Values (and other transforms doing number conversion):**
   If your data uses dot decimals, set Decimal symbol = `.` explicitly for that 
field. Any of these should unblock you.
   
   ### For the devs (proposal)
   
   I think this should be fixed. If a user sets a conversion format like `#.#` 
in the step, Hop should assume dot-decimal for parsing that field unless the 
user explicitly set symbols.
   
   Suggested fix: when a mask is present and the user hasn’t explicitly set 
Decimal/Grouping symbols, infer symbols from th pattern (dot = decimal, comma = 
grouping). Keep explicit symbol entries winning over inference for backward 
compatibility. Apply the same logic to constants used by Filter Rows.
   
   Happy to start working on a PR with tests if this approach sounds good.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to