jdkinaxis opened a new issue, #6239:
URL: https://github.com/apache/hop/issues/6239

   ### Apache Hop version?
   
   2.16
   
   ### Java version?
   
   17
   
   ### Operating system
   
   Windows
   
   ### What happened?
   
   Both jobs are executing at log level basic. I am limiting the write to log 
to only print 10 lines. The logging output of both jobs are the same, as 
expected since the log message eventually gets filtered out. However the 
instantiation of a LogMessage prior to filtering it out is extremely 
inefficient.
   
   Assuming all logRowLevel calls are wrapped in an if(isRowLevel()) check
   <img width="574" height="55" alt="Image" 
src="https://github.com/user-attachments/assets/b037ae98-33c4-4e74-baed-92aa591465f3";
 />
   Pipeline runs in 77 seconds
   
   Now I removed an isRowLevel check from just one call to logRowLevel
   <img width="562" height="64" alt="Image" 
src="https://github.com/user-attachments/assets/bb2d2584-7909-4848-83c8-80242e5c228c";
 />
   Same pipeline with same log level (Basic) takes 2 hours 11 minutes to 
complete
   
   The google sheets input is one example of a plugin that does not properly 
check if isRowLevel before calling logRowLevel
   
https://github.com/Kinaxis/hop/blob/8500bdcc5ef2dc71c8a15322f8cddf0c6e7869d4/plugins/tech/google/src/main/java/org/apache/hop/pipeline/transforms/googlesheets/GoogleSheetsInput.java#L209
   
   Ideally the filtering of log messages based on level should occur prior to 
the instantiation of log messages
   
   ### Issue Priority
   
   Priority: 3
   
   ### Issue Component
   
   Component: Transforms


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to