mattcasters opened a new pull request, #7508:
URL: https://github.com/apache/hop/pull/7508
## Summary
Fixes three of the four failing Jenkins integration tests reported in #7507
(0059-get-files-rows-count is handled in another PR):
- **opensearch.0001-opensearch-ei-test** — NPE when
`IExecutionSelector.startDateFilter()` is null (`ALL` selector). Null-safe
filter handling in OpenSearch (and Neo4j for consistency).
- **samples.0001-run-samples** — Slack sample failed because REST
`resultSplitPath` required application type JSON while the request correctly
uses FORM URLENCODED. Response JsonPath parsing is now driven by JsonPath
expressions as well as JSON app type; Slack sample is ignored in CI without
`SLACK_BOT_TOKEN`.
- **minio.0001-minio-file-handling** — Writes via pipe + unknown-size MinIO
upload left zero-length objects. Buffer-then-upload with known content length;
`createFile()` no longer closes/reuses the write stream; list cache invalidated
after upload.
### Dev / IT harness
- **`run-tests-docker.sh`**: new `CLIENT_UNZIP` option (default `true`).
When `CLIENT_UNZIP=false` and `assemblies/client/target/hop` already exists,
the client zip is not re-extracted, so a single plugin jar can be patched into
`target/hop` and re-tested quickly, e.g.
`integration-tests/scripts/run-tests-docker.sh PROJECT_NAME=minio
CLIENT_UNZIP=false`
- **`.dockerignore`**: ensure `assemblies/client/target/hop/**` is included
in the docker build context so image rebuilds pick up jar updates.
## Test plan
- [x] Unit tests: `plugins/tech/minio` (`MinioPipedOutputStreamTest`),
`plugins/transforms/rest` (`ResponseJsonParseTest` + related)
- [x] Local integration: `integration-tests/scripts/run-tests-docker.sh
PROJECT_NAME=minio` — both golden validations pass (`Test Exit Code: 0`)
- [ ] Confirm on Jenkins Hop-integration-tests that opensearch, samples, and
minio pass (0059 remains other PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
