mattcasters opened a new pull request, #7517:
URL: https://github.com/apache/hop/pull/7517

   ## Summary
   
   Fixes most of the 19 failing integration tests after the single-JVM suite 
runner (#7506) and related recent changes.
   
   ### Root causes
   
   1. **Hop-run pipelines dropped env vars** — `HopRunBase.runPipeline` called 
`pipeline.initializeFrom(null)` after the factory had already applied hop-run 
variables (project + `-e` environment). That wiped values such as `HOSTNAME` 
and `TEST_0012`. Same pattern fixed in `ActionPipeline`.
   2. **Parameter defaults clobbered parent vars** — 
`NamedParameters.activateParameters` applied empty parameter defaults over 
existing variables (e.g. `HOSTNAME=localhost` over env `http`, empty 
`BOOTSTRAP_SERVERS` over `kafka:9092`). Nested `ActionWorkflow` also now copies 
parent variables into empty parameters (same idea as hop-run).
   3. **Beam suite runner ran under Beam** — projects where `local` is Beam now 
use `hop-local` for `run-project-tests.hpl` only.
   4. **AES encoder rebind** — project hop-config said `Hop`, overwriting 
docker `AES2`; aes project/env now declare AES2 + key.
   5. **0083 contract** — WorkflowExecutor execution-result stream keeps input 
fields (#7506); test expectation updated.
   
   ### Out of scope
   
   - `samples.0001-run-samples` (age 41, chronic; needs full log to find first 
failing sample).
   
   ### Test plan
   
   - [x] `NamedParamsDefaultTest` (4 tests)
   - [x] Compile core, engine, actions
   - [ ] `CLIENT_UNZIP=false ./integration-tests/scripts/run-tests-docker.sh 
http`
   - [ ] `CLIENT_UNZIP=false ./integration-tests/scripts/run-tests-docker.sh 
kafka`
   - [ ] `CLIENT_UNZIP=false ./integration-tests/scripts/run-tests-docker.sh 
aes`
   - [ ] `CLIENT_UNZIP=false ./integration-tests/scripts/run-tests-docker.sh 
parameters_and_variables`
   - [ ] `CLIENT_UNZIP=false ./integration-tests/scripts/run-tests-docker.sh 
transforms`
   - [ ] `CLIENT_UNZIP=false ./integration-tests/scripts/run-tests-docker.sh 
beam_directrunner`
   
   Fixes #7516


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to