mattcasters opened a new pull request, #7521:
URL: https://github.com/apache/hop/pull/7521
## Summary
Jenkins remaining failures after earlier #7507 work included
`parameters_and_variables` **0004** / **0006** and samples.
### Repro finding (important)
These are **not** single-JVM suite-only failures. On a build with #7517:
```text
hop-run -e dev -r local -f main-0004-pass-variables-and-parameters.hwf →
FAIL
hop-run -e dev -r local -f main-0006-not-passing-parameters.hwf →
FAIL
```
Same outcomes as Jenkins. So the suite “loop” is not the root cause; **#7517
parameter activation** is. That also explains why the tests still match
long-standing GUI/historical semantics: empty parameter defaults mean unset,
and same-named parent CURRENT_WORKFLOW variables must not silently fill them.
### Product fix
1. **`NamedParameters.activateParameters`**
Prefer an already-set variable over the parameter default **only when the
default is non-empty** (the `HOSTNAME=localhost` clobber case from #7516).
When the default is empty, apply `""` so empty defaults still mean
“unset” (main-0004 / main-0006).
2. **`ActionWorkflow`**
Remove the #7517 parent-**variable** fallback under
`pass_all_parameters`. Formal parent **parameter** values still pass through.
Env protection for non-empty defaults remains in `activateParameters`.
3. **Unit tests** updated for the refined rule (including empty-default must
not adopt existing variable).
### Samples
Ignore `ssh-password.hpl` and `ssh-pri-key.hpl` in the samples IT ignore
list (private lab host / keys; not runnable on CI).
### Not changed
- Backbone tests **main-0004** / **main-0006** expectations (left intact).
- Full revert of #7517 (HOSTNAME non-empty-default protection kept).
## Test plan
- [x] `NamedParamsDefaultTest` — 5 tests pass
- [x] `hop-run` alone: main-0004 and main-0006 exit **0** after the fix
- [ ] Jenkins Hop-integration-tests: parameters_and_variables + samples
green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
