hansva opened a new pull request, #7542: URL: https://github.com/apache/hop/pull/7542
Resource export clones every action before serializing it, so a copy constructor that drops the name or plugin id corrupts the export: * ActionCheckFilesLocked delegated to this(), which reset the name to an empty string. The exported workflow then held an empty <name>, and the server failed with a NullPointerException from WorkflowMeta.findAction() while resolving the hops. * ActionBase's copy constructor and ActionFtpPut used the two argument super(), which dropped the plugin id. The exported action was written without its <type>, and the server failed to load the workflow with "Unable to load workflow info from XML node". The ActionBase fix covers the eleven other actions that delegate to it. Adds unit tests guarding the name/plugin id on clone, and integration test 0010 which runs a workflow containing a Check Files Locked action on a remote server through the resource export. The test fails on both bugs before this change. **Please** add a meaningful description for your change here ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
