sramazzina opened a new pull request, #7564:
URL: https://github.com/apache/hop/pull/7564

   ## What
   
   Fixes #6472. SQLite columns whose declared type carries a size written with 
a space before the parenthesis (e.g. `TEXT (50)`, `INTEGER (20)`, `REAL (10)`) 
were mistyped in the Database Explorer: `TEXT (50)` showed up as BigNumber 
instead of String, and the numeric variants were mistyped too.
   
   ## Why
   
   The SQLite JDBC driver reports those columns as `Types.NUMERIC`, so the 
generic `ValueMetaBase` mapper turns them into BigNumber/Integer. The column's 
declared **name-based type affinity** (SQLite datatype3.html ยง3.1), which the 
driver still reports correctly, is the reliable signal.
   
   ## How
   
   `SqliteDatabaseMeta` now overrides `customizeValueFromSqlType` to re-derive 
the Hop value type from SQLite's name-based affinity, correcting only the 
columns the generic mapper got wrong:
   
   - `CHAR`/`CLOB`/`TEXT` -> String
   - `INT` -> Integer
   - `REAL`/`FLOA`/`DOUB` -> Number
   - `NUMERIC`/`BLOB` -> unchanged (generic mapping kept)
   
   ## Tests
   
   - Unit tests for the affinity mapping.
   - End-to-end test driving the real SQLite JDBC driver with the exact DDL 
from the report.
   
   All sqlite module tests pass locally (`./mvnw -pl plugins/databases/sqlite 
-DskipITs test`): 12 tests, 0 failures, 0 errors.
   
   Closes #6472
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to