mattcasters opened a new pull request, #7576: URL: https://github.com/apache/hop/pull/7576
## Summary Helps unblock [@nadment](https://github.com/nadment)'s [#7550](https://github.com/apache/hop/pull/7550) / [#7549](https://github.com/apache/hop/issues/7549). Includes Nicolas's original change (shared content-editor toolbar + context menu on RCP, cut/paste capabilities on text file types) plus fixes for the three gaps he called out: 1. **RAP compile** — `IContentEditorWidget.getLanguage()` implemented on Monaco and fallback RAP widgets (CI was failing on `hop-ui-rap`). 2. **Shared toolbar on hop-web** — RAP builds `ContentEditor-Toolbar` so plugin actions (Markdown preview) show in web, not only desktop. 3. **Markdown preview listener** — `BaseGuiWidgets` resolves static toolbar methods with **assignable** parameter types (interface/facade), so `previewMarkdown(IContentEditorWidget)` works when the registered instance is `ContentEditorWidget` or a RAP widget. Preview is restored as that static method. Also dedupes content-editor i18n keys and adds a small unit test for static listener resolution. Nicolas: if you prefer to keep ownership on #7550, you can cherry-pick `d221789455` (or merge this branch) into `7549` and close this PR. ## Test plan - [x] `./mvnw -pl ui,rcp,rap,plugins/transforms/textfile -am install -DskipTests` (includes `hop-ui-rap`) - [x] `./mvnw -pl ui test -Dtest=BaseGuiWidgetsStaticListenerTest` - [x] `./mvnw -pl plugins/transforms/textfile,rcp test` - [ ] Manual RCP: open `.md` → shared toolbar Preview works; cut/copy/paste/context menu on text - [ ] Manual hop-web: open `.md` → Preview button visible and works -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
