mattcasters opened a new pull request, #7671:
URL: https://github.com/apache/hop/pull/7671

   ## Summary
   
   - Document the difference between Table Input **Limit size** (JDBC 
`setMaxRows`, client-side) and a **SQL `LIMIT`** (or dialect equivalent) in the 
query itself.
   - Call out that some drivers and engines ignore `setMaxRows` (for example 
**Generic** connections to **Dremio**), so Limit size may appear to work for 
one connection and not another (including different Pipeline Executor 
iterations).
   - Recommend server-side SQL limits for reliable caps, Generic/Dremio-style 
engines, and large-table performance.
   
   ## Related issue
   
   Closes #7667
   
   Root cause feedback from the reporter: the second Pipeline Executor 
iteration used a Generic connection to Dremio, which does not honor 
`PreparedStatement.setMaxRows()`. The first iteration used a connection that 
did honor it, so Limit size looked flaky rather than driver-dependent.
   
   ## Test plan
   
   - [x] Docs-only change; review rendered section “Limit size vs. SQL LIMIT” 
in `tableinput.adoc`
   - [ ] Confirm Options table link/cross-ref reads correctly in the 
Antora/user manual build


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to