bamaer opened a new pull request, #7699: URL: https://github.com/apache/hop/pull/7699
A transform or action that was only dragged elsewhere was reported as modified, because the visual diff compares the serialized XML and the position is part of it. The position is now left out of that comparison, controlled by a new "Ignore position in the visual diff" git option that is on by default. Also fixes getPipelineHopName, which used getFromTransform for both ends of the hop. Hops leaving the same transform all shared one name, so an added or removed hop could be matched against the wrong one and reported as unchanged. **Please** add a meaningful description for your change here ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
