mattcasters opened a new pull request, #7711:
URL: https://github.com/apache/hop/pull/7711

   ## Summary
   
   - Fixes a performance bug in the Unzip action where `closeFileSystem(...)` 
ran after **every** zip entry, forcing `java.util.zip.ZipFile` to re-parse the 
full central directory once per file.
   - Zip filesystem is now released **once** after all entries are processed 
(`releaseZipFileSystem`), including on early exit via a `finally` block.
   - Adds a regression test that subclasses the action and asserts 
`releaseZipFileSystem` is called exactly once while extracting multiple entries.
   
   Related: #2235  
   Follow-up feature idea for streaming/local unzip (avoid full VFS `findFiles` 
materialization): #7710
   
   ## Test plan
   
   - [x] `./mvnw -pl plugins/actions/unzip test -Dtest=WorkflowActionUnZipTest`
   - [x] Manual: large multi-entry zip (e.g. SEC EDGAR-style) extracts at ~1000 
files/s instead of multi-hour runtime


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to