vbhanuchander-lang commented on PR #7860:
URL: https://github.com/apache/hop/pull/7860#issuecomment-5246994900
Thanks for the review @hansva — addressed in bffe7c7.
**Artemis groupId and version.** Moved to `org.apache.artemis` and 2.55.0,
for both the client and the test-scoped embedded server, declared in
`lib/pom.xml` as before.
I verified what the move does and does not change rather than assuming: only
the Maven coordinates moved, **not** the Java packages. The reflective factory
lookup still resolves
`org.apache.activemq.artemis.jms.client.ActiveMQJMSConnectionFactory` on
2.55.0, so no source change was needed — and that is verified rather than
reasoned, because the embedded-broker test actually connects through that
factory and round-trips a message. All 18 tests still pass, and a clean build
packages only the 2.55.0 jars.
While I was in here I also pre-emptively ran `javadoc:javadoc` on this
module, because the same maven-javadoc-plugin step is what turned #7859 red — a
`{@link}` to a Lombok-generated getter, which javadoc cannot resolve. This
module is clean on that front.
Happy to take anything else, and the two follow-ups I offered still stand: a
Docker-based `integration-tests/jms` project with an Artemis service, and
promoting `IMessageQueueProvider` to a real plugin type with Kafka behind it
once you are happy with the interface shape.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
