vbhanuchander-lang commented on PR #7859:
URL: https://github.com/apache/hop/pull/7859#issuecomment-5246996185
The Code job failure is fixed in 802b850.
The cause was in this PR, not flaky infrastructure: the class javadoc on
`SparkSqlMeta` linked `{@link #getViews()}`, which Lombok generates from the
`@Getter` on the field, so javadoc cannot resolve the reference:
```
SparkSqlMeta.java:92: error: reference not found
```
`maven-javadoc-plugin` fails the build on that, which is why **Hop PR Build
(Code)** went red while **(Documentation)** passed — the failure was in the
javadoc goal of `hop-engines-spark`, not in the tests. Replaced it with a
`{@code views}` reference, which needs no resolution.
Verified by isolating it rather than guessing: `javadoc:javadoc` on
`plugins/engines/spark` fails on this branch and passes on `main`, and is green
again after the change. The module's Spark SQL tests still pass (18), and I
have run the same goal on my other open branch pre-emptively.
Two other test failures appear in that run —
`HopVfsSingleManagerTest.noMetadataLookupBeforeVariablesArrive` and
`ExcelInputMetaTest` (`testSerialization`, `testClone`). Those are in modules
this PR does not touch, and the build reached `BUILD FAILURE` on the javadoc
goal, so I have left them alone rather than claim anything about them. Let me
know if you would like me to look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
