mattcasters opened a new pull request, #8107:
URL: https://github.com/apache/hop/pull/8107
## What
Fixes #8057.
Plugin icons in the new transform/action palette tree were rasterized at a
raw 16×16, while folder icons in the same SWT `Tree` (and explorer file-type
icons) already used Hop's zoomed small-icon size (`zoomFactor * 16`).
On Windows the native tree `ImageList` takes its slot size from the first
image and stretches the rest. That made transform and action icons look
pixelated or distorted, including at 100% OS scale / 100% Hop UI zoom, because
`PropsUi.getZoomFactor()` is font-metric based and is often not 1.0.
This change:
- Adds `ConstUi.zoomedIconSize()` with the same truncation as explorer
(`(int) (zoomFactor * logicalSize)`).
- Adds `GuiResource.getSmallIcon()` so tree icons share that path with
folder/toolbar images.
- Switches `GraphPaletteTree.iconFor()` to `getSmallIcon()` for transform
and action plugins.
## How to test
1. Show the pipeline and workflow palette trees.
2. Compare plugin icons to category folder icons in the same tree, and to
explorer file-type icons. Bounds/`ImageList` size should match; icons should
look crisp rather than stretched.
3. On Windows, re-check the setups from #8057:
- OS 100% + Hop UI zoom 100% + `-Dswt.autoScale=exact`
- OS 100% + Hop UI zoom 100% + `-Dswt.autoScale=quarter`
- OS 150% + Hop UI zoom 100% + `-Dswt.autoScale=exact`
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Run `mvn clean install apache-rat:check` to make sure basic checks
pass. A more thorough check will be performed on your pull request
automatically.
- [x] If you have a group of commits related to the same change, please
squash your commits into one and force push your branch using `git rebase -i`.
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
