sramazzina opened a new pull request, #8109: URL: https://github.com/apache/hop/pull/8109
Preview and Apply threw a HopSetupException, and once that was out of the way Apply took over two minutes. Five defects: - The Windows launchers rewrote HOP_OPTIONS in place, so the java child inherited the expanded flag list, quotes included. They now accumulate into _HOP_OPTIONS, which also stops the list from growing at every start. - The dialog seeded its HOP_OPTIONS field from that value; the snapshot now discards values carrying the launcher-only -DHOP_PLATFORM_RUNTIME marker. - EnvValueEscaper rejected " % ! & | < > ^ instead of escaping; it now renders the whole set statement. "!" stays rejected because hop.bat enables delayed expansion before sourcing hop-env.cmd. - Apply hung forever: powershell.exe kept reading the stdin pipe that Java never closed. The write end is now closed right after start. - Apply still took minutes: writing user-level variables makes Windows broadcast an environment change to every top-level window and wait for a reply that the blocked user interface thread could not send. The applier now runs in a ProgressMonitorDialog, keeping the event loop alive. Fixes #8087 **Please** add a meaningful description for your change here ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
