mattcasters opened a new pull request, #8120: URL: https://github.com/apache/hop/pull/8120
**Please** add a meaningful description for your change here Fixes #8114 Opening the pipeline or workflow Run Options dialog (F8) did not put keyboard focus on Launch. `setDefaultButton` is enough for Enter, but Space only activates the focused control. Focus landed on Cancel, the run-configuration combo, or a Parameters cell editor, so F8 then Enter/Space did not start the run. This change: - Focuses Launch after the shell is activated (and still queues an `asyncExec` for Hop Web). - Stops `TableView.clearAll()` from opening a cell editor when the grid is not yet visible, so filling Parameters/Variables before `shell.open()` cannot steal focus. Interactive Clear All on an open grid is unchanged. SWTBot tests cover Launch keeping focus despite a competing table `setFocus`, and `clearAll()` before vs after the shell is shown. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
