mattcasters opened a new pull request, #8144:
URL: https://github.com/apache/hop/pull/8144

   ## What
   Execute SQL script can load the script from a VFS SQL file instead of only 
storing it in the pipeline XML 
([#7151](https://github.com/apache/hop/issues/7151)). The dialog is reorganized 
onto three tabs.
   
   ## Changes
   - Add `sql_from_file` (same pattern as Table Input / Database Join): when 
set, SQL is read from that path at transform init; variables in the path are 
resolved; the editor is a read-only preview.
   - Restyle the dialog with `GuiCompositeWidgets` tabs:
     - **General**: connection and insert/update/delete/read stats fields
     - **SQL**: filename, script editor, execute for each row, single 
statement, variable substitution, quote strings
     - **Parameters**: bind parameters and the argument table (`Get Fields` 
remains on the button bar)
   - Unit tests for `getEffectiveSql`, load/save of `sqlFromFile`, and disabled 
GUI widgets
   - Integration test `0019-execute-sqlscript-sql-file` (inline SQL is a dummy 
`SELECT 1`; the file is the source of truth)
   - User-manual page updated with screenshots of the three tabs
   
   Fixes #7151


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to