bamaer opened a new pull request, #8153: URL: https://github.com/apache/hop/pull/8153
The key handler is attached to every widget from PropsUi.setLook(), so it also covers widgets that are created after their shell was set up. Composite widgets that pass their listeners on to a control inside them are skipped: they style themselves before creating that control, so it is not there yet, and it gets the handler through its own setLook() call anyway. That check only recognised widgets overriding addKeyListener(). Widgets like MetaSelectionLine and StyledTextComp override the addListener() that Control.addKeyListener() ends up calling instead, so they were not skipped and opening a metadata editor threw a NullPointerException on the control that was not created yet. Recognise both ways of delegating. Only Hop Web was affected: RAP's Control.addKeyListener() calls the public addListener(), while SWT on the desktop routes it through the internal _addListener() that subclasses cannot override. **Please** add a meaningful description for your change here ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
