mattcasters opened a new pull request, #8185: URL: https://github.com/apache/hop/pull/8185
Filter Rows (and other `Condition` users) still fail when a Date constant was saved with Hop's canonical text (`yyyy/MM/dd HH:mm:ss.SSS`) and a different user mask such as `yyyy-MM-dd`. Evaluation parsed the stored text with the user mask and threw; reopening the constant in the editor hit the same conversion and could not be edited. This hardens `Condition.CValue.createValueData()` to try the stored mask first, then the compatible Hop date format, then the type default. Date/Timestamp only; numeric constants are unchanged. Empty date masks are persisted so later loads do not depend on `HOP_DEFAULT_DATE_FORMAT`. The condition editor now keeps the stored text when conversion fails (legacy XML or a variable), and Join Rows passes variables into the same editor. fixes #3051 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
