sramazzina opened a new pull request, #8190:
URL: https://github.com/apache/hop/pull/8190
- The file explorer offered no way to create anything: added Create pipeline,
Create workflow and Create file entries to the tree context menu, above
Create folder.
- No explorer file type declared CAPABILITY_NEW, so no type could be offered
for creation: added it to the JSON, TXT, XML, YAML, SQL and Python types.
- The Create folder context menu item was enabled on files, where it would
have treated the file path as the parent folder: all four creation entries
now require a single selected folder.
- Pipelines and workflows could only be created as unnamed, unsaved tabs:
they are now named, written into the selected folder and opened already
saved.
- Typed names were concatenated onto the folder path unchecked, so a name
carrying a separator or a percent-encoded traversal created the file
outside the selected folder: the resolved path's parent is now verified
against the selected folder.
- Nothing stopped an existing file from being reused: every creation path
refuses an existing file instead of overwriting it.
Fixes #8135
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks
pass. A more thorough check will be performed on your pull request
automatically.
- [ ] If you have a group of commits related to the same change, please
squash your commits into one and force push your branch using `git rebase -i`.
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
