sramazzina commented on PR #8172:
URL: https://github.com/apache/hop/pull/8172#issuecomment-5477734038

   This looks great, and the `locale-us` / `locale-eu` integration tests are a 
really nice touch — that is the kind of coverage we never managed to add on our 
side.
   
   One question out of curiosity: why did `formatLocale` and `timeZone` end up 
on the lifecycle environment rather than on the project? Just trying to 
understand the reasoning behind the choice.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to