sramazzina commented on PR #8159: URL: https://github.com/apache/hop/pull/8159#issuecomment-5477121025
Thanks for picking this up, and for the `ValueMetaBase` constructor fix in particular — that is the same defect we had chased on the comparison path, and we missed the assignment side of it entirely. One thought that came up while reading the commit, purely as an observation. The new `logEffective()` line reads as a start-up line, and for `hop-run` and `hop-server` that is exactly what it is: one line per process. In the GUI it also fires during normal use, because our `ConfigRegionalSettingsTab.save()` calls `applyGui()` on every widget event — so a user trying out the tab, ticking a checkbox, picking a locale, changing their mind, ends up writing a long run of near-identical `Regional settings: …` lines into the log. That is our side meeting your call site, nothing you could have seen from yours. What made us stop on it is Hop Web, where that tab is reachable and the process is a long-lived server. There the noise is not transient: it accumulates in a server log that outlives the session, mixed in with everything else that log is meant to carry. No strong opinion on the fix, and it may well not be worth the churn. Happy to push something small here if you want it handled, otherwise feel free to leave it as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
