bamaer opened a new pull request, #8213: URL: https://github.com/apache/hop/pull/8213
The PGP encrypt dialog filled its grid in column order but read it back one column out of step, so opening a working action and pressing OK moved the wildcard into the User ID and the signing key into the destination path. Broken in 2.18.0 by #6940, fixed in 2.18.1 by #7282. These tests pin that down and prove signing works end to end. - ActionPGPEncryptFilesDialogTest: SWTBot coverage of the grid round trip, verified to fail against the 2.18.0 column mapping - ActionPGPEncryptFilesSignTest: sign/verify and sign+encrypt/decrypt against a real gpg and a throwaway keyring, skipped when gpg is absent - integration-tests/pgp: the same two round trips as hop-run workflows - gnupg added to the integration-test image; ubuntu:22.04 ships only gpgv **Please** add a meaningful description for your change here ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
