mattcasters opened a new pull request, #8279:
URL: https://github.com/apache/hop/pull/8279

   Follow-up hardening for the Database perspective from #8212.
   
   **#8277**
   - SQL editor tabs have one owner across the perspective, floating window, 
and dock, so Float/Dock no longer overwrite each other's buffers.
   - Table preview SQL uses both prefix (`TOP` / `FIRST`) and suffix (`LIMIT`) 
clauses; Generic connections forward the prefix as well.
   - Failed connects and SQL runs are logged and shown in Results/Messages and 
on the operations line (with tooltip), instead of staying silent.
   - File > Save / Close from Float or Dock act on the SQL tab that enabled the 
toolbar; untitled close uses this tab's Save As; closing the floating window 
asks about dirty tabs.
   - Closing a SQL/table-info tab disposes its control (and dock tool content), 
so KeyDown filters and metadata listeners do not leak.
   - File-backed SQL tabs implement `reload()`, and several editors can watch 
the same path without one close unwatching the others.
   - `SELECT … FROM … INTO @var` / `INTO OUTFILE` is classified as non-query; 
`INTO` in string literals or subqueries stays a query.
   - Generate DDL / suggested SQL mark untitled tabs dirty so close prompts to 
save.
   - Operations list has a Clear action, a cap of 50 finished rows, clears on 
project switch, and drops the attached `Database` / cached `DatabaseMetaData` 
when done.
   
   **#8278**
   - Query result grids follow the rows dialog: 
`HOP_BINARY_FIELDS_AVOID_HEX_PREVIEW`, hex for binary, and column/cell type 
tooltips.
   
   Fixes #8277
   Fixes #8278
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   - [x] Run `mvn clean install apache-rat:check` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
   - [x] If you have a group of commits related to the same change, please 
squash your commits into one and force push your branch using `git rebase -i`.
   - [x] Mention the appropriate issue in your description (for example: 
`addresses #123`), if applicable.
   
   To make clear that you license your contribution under the [Apache License 
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to