mattcasters commented on PR #8265: URL: https://github.com/apache/hop/pull/8265#issuecomment-5574280682
Took the essential items from the review and pushed a follow-up: 1. **Bare folder discovery** — `detectConfigFilename` now returns null when there is no project config. A normal project folder is registered as itself, not as `.git` / `datasets` / `metadata`. A parent of several project folders still discovers those children. 2. **`variables.json` / `metadata.json`** — applied only for zip/jar homes or a JSON-export layout (dump files and no `metadata/` folder). A regular project with a `metadata/` folder is unchanged. Each file is read once per enable. 3. **Double enable** — the subcommand mixin skips a second full enable of the same project/environment (still copies the metadata provider onto the command). 4. **`-im` too late** — `-im` / `-pl` / `--environments` set `HOP_CONFIG_IN_MEMORY` before `HopEnvironment.init()`, so a pristine config folder is not created on first run. 5. Also: `hop-config.json` is no longer a project-config candidate; leaving in-memory mode keeps a no-file serializer if the config file is absent; quoted location tokens no longer keep the quote characters. Docs updated for the bare-folder behaviour and that `hop-gui.sh` does not take `--project-locations`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
