mattcasters commented on PR #8244: URL: https://github.com/apache/hop/pull/8244#issuecomment-5603103001
Thanks @bamaer — addressed in c9336ecc98: **Blocker (Get Fields error dialog)** Dropped the extra `monitor.done()` in `GetQueryFieldsProgressDialog`. `ProgressMonitorDialog` still disposes in `runMonitoredWork`'s `finally`, and `pumpDisplayUntilShellDisposed` now re-checks `targetException` / `interruptedException` after the loop so a failed Get Fields still surfaces the error dialog. **PostgreSQL NUMERIC** `NUMERIC(p, s)` now uses `p = max(length, scale)` so PostgreSQL < 15 does not reject scale > precision. The `Number(5,7)` test expects `NUMERIC(7, 7)`. The 2.20 meaning (`NUMERIC(length, scale)` rather than `length+precision`) is noted on the PostgreSQL connection page and in the column-types dev doc. **getQueryFieldsFallback** Fallback is only used to recover from the prepared-statement / data-service paths. The ordinary JDBC branch already ran it; a second call would execute the SQL twice. **Follow-ups included** - SQL Server: Hop `TYPE_TIMESTAMP` is checked before original `Types.DATE`, so a DATE column converted to Timestamp generates `DATETIME2`. - Parameter metadata: unsized `NUMERIC`/`DECIMAL` (precision 0, scale 0) maps back to Integer. - `quoteSchema`: splitting `catalog.schema` without the `supportsCatalogs()` gate is intentional (comment in `DatabaseMeta`). A schema whose name contains a literal dot is the rare case; `mydb.dbo` as one identifier was the bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
