bamaer opened a new pull request, #8307: URL: https://github.com/apache/hop/pull/8307
…rules usable Select Values applies its tabs in order, each to the row the one before it produced, but check() compared all of them to the incoming row. A field renamed on "Select & Alter" was reported missing by the Metadata and Remove tabs, which only ever see the new name. Selecting the same field twice is how a value is copied under a second name, so the duplicate check now counts the names fields leave under. Two fields leaving under one name still is. Hop's check() methods were written for the Verify button and work from the design-time row stream. The linter repeated them unprompted at whatever severity the transform picked, with no rule able to say otherwise. A new `type: native` rule classifies them and the core pack reports them at warning; naming-scheme remarks come through the same door. The rest is the default rules meeting real projects: - TRANS-002 and WORKFLOW-002 reported on the file, so the warning could not name the transform it was about. They now report on the element. A file holding a single transform is no longer an orphan, and neither is one whose hops are disabled: that is what STRUCT-003 asks, and it ships off. - SEC-002 and SEC-003 matched any field merely containing "token" or "secret", at any type, putting three hardcoded-secret errors on every Token Replacement transform. **Please** add a meaningful description for your change here ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
