bamaer opened a new pull request, #8323: URL: https://github.com/apache/hop/pull/8323
…input stream Text File Input and vCard Input were the only file input transforms where the filename field was a free-text box. Both now use a CCombo filled on focus with the fields of the transform named in 'Accept filenames from transform', falling back to all previous transforms when none is selected. Two vCard Input defects surfaced while testing this and are fixed here: - VCardInputMeta listed the accept_filenames, accept_transform_name, accept_field, passing_through_fields and add_to_result_filenames keys in childKeysToIgnore, copied from JsonInputMeta which does not use them. They were never written to or read from the pipeline file, so the settings were silently dropped on save. Removing the list also exposes them as metadata injection keys. - VCardInput prepared its output row metadata on the first processRow(), which needs getInputRowMeta(); that is only populated after the first getRow(). Reading filenames from the stream failed immediately. The metadata is now prepared after the first row is read. Adds unit tests for both defects and integration test 0111 covering the accepting path end to end. **Please** add a meaningful description for your change here ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
