mattcasters opened a new pull request, #8329:
URL: https://github.com/apache/hop/pull/8329

   Stop pipelines from hanging when a main hop feeds a transform that never 
calls `getRow()` (#2641 / HOP-3836), and label which transforms can start 
without incoming hops (#2681 / HOP-4186).
   
   ## What changed
   
   Two independent instance methods on `ITransformMeta` (not `@Transform`, so 
dual-mode options work):
   
   - `consumesMainInput()` defaults to **true** so third-party plugins keep 
accepting hops.
   - `canStartWithoutInput()` defaults to **false**. Get Variables both starts 
without a hop and still drains hops when they are present.
   
   Hops into a never-consume transform are refused in Hop Gui, flagged by 
Verify (with a dialog-option hint when there is one), fail `init()`, and 
`setOutputDone()` stops the pipeline if leftover main input remains. Info and 
error hops stay valid. Leftover rows are not silently drained.
   
   Pipeline sources are labeled in the add-transform dialog (search `pipeline 
source`), canvas tooltips, Verify comments, and a new user-manual page.
   
   Known never-consume-at-default plugin IDs live in 
`never-consume-at-default-plugins.txt` and are checked when those plugins are 
on the test classpath.
   
   addresses #2641
   addresses #2681
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   - [x] Run `mvn clean install apache-rat:check` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
   - [x] If you have a group of commits related to the same change, please 
squash your commits into one and force push your branch using `git rebase -i`.
   - [x] Mention the appropriate issue in your description (for example: 
`addresses #123`), if applicable.
   
   To make clear that you license your contribution under the [Apache License 
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to