rmannibucau commented on issue #8321: URL: https://github.com/apache/hop/issues/8321#issuecomment-5634184912
@hansva https://github.com/apache/hop/blob/main/core/src/main/java/org/apache/hop/core/logging/LoggingBuffer.java, https://github.com/apache/hop/blob/main/core/src/main/java/org/apache/hop/core/logging/LoggingPrintStream.java, https://github.com/apache/hop/blob/main/core/src/main/java/org/apache/hop/core/logging/LogChannel.java (and siblings) and https://github.com/apache/hop/blob/main/core/src/main/java/org/apache/hop/core/logging/HopLogStore.java . Idea there is to keep the minimum to not break (mainly the UI and API) but not rely on it for most cases. Another round can break this latest dependency to the legacy manual logging if desired but while overridable with a custom log4j2 config it is already a big step forward. the abstraction - links - doesn't enable any switch until you do use slf4j so this PR just assumes it and make the default _hardcoded abstraction_ just default config of the logging framework so everything is back to its proper stage IMHO - was the spirit of the PR, indeed backward compat required way more changes than just that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
