leehaut opened a new pull request, #8322:
URL: https://github.com/apache/hop/pull/8322
## Summary
- `LoadScriptFromTab` no longer swallows exceptions in an empty catch.
Missing tabs and script evaluation failures now throw a Rhino runtime error
immediately, instead of failing later with misleading errors such as `xxx is
not defined`.
- Added Rhino unit tests for successful load, missing tab, and invalid
script.
- Added a happy-path integration test
(`0087-javascript-loadscript-from-tab`) wired into `main-0087-javascript.hwf`.
- Updated `jsFunctionHelp.xml` to document that missing or invalid tabs fail
the transform.
## Test plan
- [x] `mvn -pl plugins/transforms/javascript -am test
-Dtest=ScriptValuesAddedFunctionsRhinoIntegrationTest
-Dsurefire.failIfNoSpecifiedTests=false`
- [x] Re-run a pipeline that calls `LoadScriptFromTab("DoesNotExist")` and
confirm it fails with `Unable to find script tab "DoesNotExist"` (not a later
undefined-function error)
- [x] Run transforms IT workflow `main-0087-javascript.hwf` (includes the
new loadscript unit test)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
