beatum commented on PR #8339:
URL: https://github.com/apache/hop/pull/8339#issuecomment-5659912769
Thanks for your time and patience. I will continue learning and improving
throughout this project.
Here is my latest update. 😊
**1.Database.java**
- a. deidcated function ``SqlParameterSpec`` which can support for JDBC
parameter marker also ```?{name}```
**2.DatabaseJoin.java**
- a. Removed unreachable fallback in lookupValues():
- no longer reparses SQL from meta.getEffectiveSql(...);
- uses data.parameterSpec directly and throws explicit error if
unexpectedly null.
- b. Removed custom runtime output field-name dedupe helpers
```isOutputFieldNameInUse``` and ```createUniqueOutputFieldName``` respectively.
- c.Runtime metadata appending now sets base field name and relies on```
RowMeta.addValueMeta()``` for deduping, aligning naming behavior with design-
timeflow.
**3. DatabaseJoinMeta.java**
- a. ```parseSqlParameterSpec(...)``` now delegates to
```Database.parseSqlParameterSpec(...)``` single parser source of truth.
- b. ```getTableFields(...)``` now uses parsed/prepared SQL getPreparedSql()
instead of raw SQL, so ?{name} never goes directly to JDBC.
- getFields(...) metadata parameter typing updated:
- prefer incoming stream type when field exists in prev;
- fallback to declared ParameterField type otherwise;
- keep parameter row values null (removed dummy typed values).
- c. Stored-procedure handling tightened:
- in ```getFields()```, connection failures are no longer swallowed by
stored-proc deferral.
- in ```getTableFields()```, stored-proc metadata probe failures are
deferred detailed/debuginstead of hard error logging.
- d. check(...) now reports error when SQL is empty ,instead of silently
skipping query validation.
- Positional parameter missing checks improved:
- now verifies both declaration and existence in incoming row;
- reports missing positional field names clearly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
