mattcasters opened a new issue, #8387: URL: https://github.com/apache/hop/issues/8387
### Apache Hop version? 2.20.0-SNAPSHOT / current mainline (after #8356) ### Java version? Java 21 (GitHub Actions Temurin) ### Operating system Linux ### What happened? GitHub Actions PR builds fail while resolving `hop-ui-rcp` with: ```text Failed to execute goal on project hop-ui-rcp: Could not resolve dependencies for project org.apache.hop:hop-ui-rcp:jar:2.20.0-SNAPSHOT dependency: org.eclipse:org.eclipse.tm4e.core:jar:2.20.0-SNAPSHOT (compile) Could not find artifact org.eclipse:org.eclipse.tm4e.core:jar:2.20.0-SNAPSHOT ``` This is not a missing Eclipse Maven Central artifact. `lib-p2/tm4e` wraps Eclipse TM4E 0.17.2 from `download.eclipse.org` and installs it locally under Hop's version. That wrapper is never published (`maven.deploy.skip=true`, and it is excluded from the snapshot wagon deploy). Full pushes to `main` still work because GIB is disabled there (`GIB_DISABLE=true`) and the wrapper stays in the reactor. PR jobs enable gitflow-incremental-builder (`-Dgib.disable=false`). GIB then: 1. Builds changed modules (for example `hop-ui`) 2. Builds downstream of those (`hop-ui-rcp`, plugins, …) 3. With default `buildUpstreamMode=changed`, only rebuilds upstreams of *directly changed* modules A `hop-ui` change therefore selects `hop-ui-rcp` as downstream, but drops `org.eclipse.tm4e.core`. Maven then looks for `org.eclipse:org.eclipse.tm4e.core:jar:2.20.0-SNAPSHOT` in repositories and fails. Seen on PR run https://github.com/apache/hop/actions/runs/34902019371 ("Polishing the database exploration dialog"): the GIB reactor included the SWTBot wrapper (upstream of changed `hop-ui`) but not the TM4E wrapper. The shared `~/.m2` cache does not reliably save this either, because incremental jobs can populate the same cache key without installing the wrapper jar. The SWTBot wrapper (`org.eclipse.swtbot.swt.finder`) has the same unpublished P2-wrapper shape and can hit the same hole on a different change set. **Suggested fix:** keep the unpublished `lib-p2` wrappers in every incremental reactor, for example: ```xml <gib.forceBuildModules>org.eclipse.tm4e.core,org.eclipse.swtbot.swt.finder</gib.forceBuildModules> ``` ### Issue Priority Priority: 2 ### Issue Component Component: Infrastructure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
