mattcasters opened a new pull request, #8423: URL: https://github.com/apache/hop/pull/8423
Fixes #8366 Restored SQL editor tabs in the Database perspective were marked as changed, so Hop Gui asked to save them on close even when the user had not edited them in the current session. ### What changed - Untitled session buffers restore clean. Hop already persists those buffers; close should not prompt to save them as a file unless the user edits after restore. - Named `.sql` files that were dirty when Hop closed stay dirty so the user can still save them. - After restore, clean tabs call `markClean()`. Modify events from loading the editor are ignored while restoring, and ignored when the text still matches the loaded/saved/restored baseline. ### Tests `DatabaseSqlEditorTabTest`, `DatabaseSqlTabMemoryTest` (and related Database workbench unit tests). ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
