rmannibucau commented on PR #8304: URL: https://github.com/apache/hop/pull/8304#issuecomment-5716708208
> On top of that: we'd need real integration tests that run pipeline for the formulas in both fast and POI mode to make sure they both produce the exacte same result for every individual function, combination of functions etc. note on that: it is built in since first commit > No matter how you look at it, this is bound to become a (partial) POI clone. partly but the costly part of POI is not the computation, itis all the rest and the fact we can support partly and still be 100% accurate with the POI fallback means we can get really significant boost for low investment (this PR is literally an blocker -> enabler game changer for Apache Hop adoption) the "other"/new component is just way too hard to understand IMHO, in the UI when you will select a transform you will have "formula or formula", best case you get "slow but complete formula VS fast but partial formula". I don't see how it can be defended from an UX/end user perspective so I'm very hesitating to go that route. > If your issue is Pentaho migration, you can just revive the old code outside of an Apache repository like @mattcasters did [here](https://github.com/ProjectDataHopper/hop-pentaho-formula) guess you know the story there, it is built-in or it is custom and more you pull custom code less you need the built in, so trying to push strong on the _standard_ Apache Hop solution there. More on a technical aspect there is no real technical justification (I understand the licensing etc) to use Apache POI for data but small ones so think this critical component should get more love. Now, if you all converge to say me we deprecate the Apache POI component in next minor and clearly state we move to the "new" one and drop the POI one in next major then I will totally align on creating a new one, if not I don't see splitting as positive for end users. (sorry for the big post) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
