bamaer opened a new pull request, #8481: URL: https://github.com/apache/hop/pull/8481
Restores the Explorer tab context menu after #8450 stopped attaching it to the folder. ExplorerPerspective read the menu via CTabFolder.getMenu(), which has returned null since 2c56ee9f89, so new MenuItem(menu, ...) threw and the Explorer perspective failed to initialize on startup (#8479). It also kept its own MenuDetect listener to track the clicked tab. Because TabCloseHandler now pops the menu from its MenuDetect listener — registered first — SWT.Show fired before that target was updated, leaving Move to Right / Move Down / Join Left / Join Above disabled or acting on the previous click. This undid #8458 / #8459. Both now read the tab from TabCloseHandler, which sets it before showing the menu. The menu stays unattached, so #8443's behaviour is unchanged. Tested on Linux desktop and Hop Web, test on MacOS and Windows pending. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
