mattcasters opened a new pull request, #8576: URL: https://github.com/apache/hop/pull/8576
Ctrl/Cmd+Left and Ctrl/Cmd+Right in a text field were taken by Align Left and Align Right whenever that shell was registered with the keyboard handler. That cancelled the native word move, including in the VFS file dialog filename field. Alt+Right was taken by Distribute Horizontally, so on macOS Option+Right did not move to the next word. On Hop Web those chords were also cancelled in the browser, so a normal text field never moved the caret. The SQL editor already moved by word, because StyledText handles the keys itself when nothing cancels them. Copy and cut only acted on a selection. With nothing selected they did nothing. This change: - Leaves horizontal Ctrl/Cmd/Alt+Left/Right in a text field, and in the Monaco editor. On Windows and Linux that is word movement. On macOS Option+Left/Right is word movement and Command+Left/Right stays the start or end of the line, matching StyledText. Shift still extends the selection. Ctrl+Alt+Left is still previous file. The canvas shortcuts still run when focus is not a text field. - Copies or cuts the current line, including its line break, when nothing is selected. A selection still wins. Password fields are unchanged. Read-only text can copy the line and is not cut. The multi-line editor toolbar and pop-up menu do the same. - Stops cancelling those word-movement keys in Hop Web, so the browser moves the caret. An empty Ctrl/Cmd+C or Ctrl/Cmd+X is handled in the page while the key is still pressed. Monaco copies or cuts the current line when nothing is selected. Verified with `HopGuiKeyHandlerTest`, `TextLineClipboardTest`, and `HopWebEntryPointTest`. Not exercised in a running Hop GUI or Hop Web session. fixes #8362 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
