mattcasters commented on code in PR #8609:
URL: https://github.com/apache/hop/pull/8609#discussion_r4106460208
##########
engine/src/main/java/org/apache/hop/www/PrepareExecutionPipelineServlet.java:
##########
@@ -144,7 +144,8 @@ public void doGet(HttpServletRequest request,
HttpServletResponse response)
pipelineConfiguration.getPipelineExecutionConfiguration();
// Set the appropriate logging, variables, arguments, replay date, ...
// etc.
- pipeline.setVariables(executionConfiguration.getVariablesMap());
+ applyClientVariables(
+ pipeline, executionConfiguration.getVariablesMap(),
pipelineConfiguration.isExported());
Review Comment:
**[suggestion]** `isExported()` stays false unless registration called
`setExported(true)`. `RegisterPackageServlet` does that, but `/hop/addExport`
(`AddExportServlet`) still stores a plain `PipelineConfiguration` and then
comes through this prepare call. Previously prepare copied the client variable
map as-is, so an exported pipeline kept the client's `PROJECT_HOME`. On a
server started with a real project, `applyClientVariables` now overwrites those
project variables and the export's client-relative paths no longer match.
**Suggestion:** Set `exported` on the configuration `AddExportServlet` puts
in the pipeline map, the same way `RegisterPackageServlet` does, before this
prepare step runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
