mattcasters opened a new pull request, #8633: URL: https://github.com/apache/hop/pull/8633
Opening the JavaScript transform dialog and pressing Cancel warned that the content had changed, even when nothing was edited. The script tab loads its text through the shared content editor. `setText()` notifies modify listeners on the next event-loop turn, after the dialog has restored the transform's original changed flag, so the dialog looked edited as soon as it opened. Tabs are now loaded with `setTextSuppressModify()`, and the dialog keeps the standard modify listener that ignores events while the dialog is filling in. The content editor also skipped a null main menu. Building the editor before Hop has created that menu threw a null-pointer exception. The menu update now skips a missing menu the same way it already skips a missing toolbar. fixes #8564 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
