mattcasters opened a new pull request, #8673:
URL: https://github.com/apache/hop/pull/8673

   The User Defined Java Class page listed the dialog options without saying 
which method runs, how a class reads a field, or what the info, target, and 
Test class controls actually do. A few of the code samples did not match the 
current API.
   
   The page now follows the transform: the class body Janino compiles, the 
`init` / `processRow` / `dispose` lifecycle, and a complete example that reads 
parameters and input fields and writes an output field. It explains why an info 
hop is not the main input, that both the info and target tables can hold 
several rows, what a tag is for, and why those rows are still required after 
the hops are drawn. Test class is described as a throwaway preview on generated 
rows, including the info and target stand-ins. The old samples that called 
`inputRowMeta()` and `getInteger` on a field helper are replaced with the 
methods the class actually has.
   
   This is a documentation-only change, so no Maven tests were run.
   
   fixes #2368
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
   - [x] If you have a group of commits related to the same change, please 
squash your commits into one and force push your branch using `git rebase -i`.
   - [x] Mention the appropriate issue in your description (for example: 
`addresses #123`), if applicable.
   
   To make clear that you license your contribution under the [Apache License 
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to