mattcasters opened a new pull request, #8679: URL: https://github.com/apache/hop/pull/8679
Beam's Flink runner result does not carry the job id that Flink logs when a pipeline is submitted (`Successfully submitted job ... (job-id)`). After `prepareExecution()` and `startThreads()`, callers had no way to read that id, including when the attached run later failed. Hop now chooses the Flink job id before submission and writes it into the Flink configuration directory as `$internal.pipeline.job-id`, preserving an existing `FLINK_CONF_DIR` or `flinkConfDir`. `BeamFlinkPipelineEngine.getFlinkJobId()` returns that id. It is also logged, stored on the execution state as `flink.job.id`, and shown on the execution viewer info tab. A `[collection]` master does not submit a cluster job, so no id is assigned. `./mvnw -pl plugins/engines/beam test -Dtest=FlinkJobConfigurationTest,BeamFlinkPipelineEngineTest -Dsurefire.failIfNoSpecifiedTests=false` passed (6 tests). A live remote Flink cluster was not used. fixes #3131 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
