mattcasters opened a new pull request, #8681: URL: https://github.com/apache/hop/pull/8681
Combination lookup/update stores a signed integer hash of its key fields, but that calculation stayed inside the transform. Add a checksum could not reproduce it, and the lookup could not use a hash that had already been calculated. Add a checksum now has a Hash code type. It hashes the native field values the same way Combination lookup/update does, including nulls, and returns that value as an integer. Prefix, separator and suffix are ignored for this type so the result stays comparable. The selected fields have to be the key fields, in the same order. Combination lookup/update has a Hash field in stream option. When that integer field is set, its value is written to the hashcode column and used for the lookup. When the field is empty, the transform still calculates the hash from the key fields. The key fields are still compared, so a hash collision does not select a different row. `./mvnw -pl plugins/transforms/checksum,plugins/transforms/combinationlookup test -Dtest=CheckSumTest,CheckSumMetaTest,CheckSumMetaInjectionTest,CombinationLookupMetaTest,CombinationLookupHashTest,CombinationLookupLineageTest -Dsurefire.failIfNoSpecifiedTests=false` passed. A full reactor build and the GUI were not run. fixes #3460 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
