mattcasters opened a new pull request, #8685: URL: https://github.com/apache/hop/pull/8685
Filter Rows, Switch/Case, and similar transforms deliver a named target stream to copy 0 of the chosen transform only. Hop already refused a copy count above 1 on that target, but the check ran only from the copies dialog. A transform that already ran in multiple copies could still receive a hop from the filter, and it could be dropped onto the hop between the filter and the next transform. Both paths record it as the target, so every row is sent to copy 0. Creating a target-stream hop is now refused when the destination's copies string resolves to more than one. Splitting a hop is refused when that split would move a named target onto a multiple-copy transform. Both show the existing "multiple copies are not allowed here" warning. A plain main-output hop is still allowed, because those rows are distributed across copies. The copies action uses the same rule. `./mvnw -pl engine test -Dtest=PipelineMetaMultipleCopiesTest -Dsurefire.failIfNoSpecifiedTests=false` passed (12 tests). `tools/with-isolated-display.sh ./mvnw -pl ui -am compile -DskipTests` succeeded. The dialogs were not exercised in an SWT test. fixes #4010 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
