mattcasters opened a new pull request, #8687: URL: https://github.com/apache/hop/pull/8687
Pentaho's Kafka consumer stores its sub-transformation in `transformationPath`. A repository reference, and a filename that PDI loads by appending `.ktr` itself, has no extension. Hop renames that element to `pipelinePath` and rewrites a `.ktr` suffix to `.hpl`, but a path that never had an extension is left unchanged. Opening the referenced pipeline then fails: the imported file is `name.hpl` while the path still points at `name`. The Kettle import now adds `.hpl` when a Kafka consumer pipeline path's last segment has no extension. Paths that already end in `.hpl` are unchanged, a trailing slash is left as a folder, and an uppercase `.KTR` suffix is rewritten to `.hpl`. This covers both `KafkaConsumerInput` and `KettleKafkaConsumerInput` (the latter is still renamed to `KafkaConsumer`). Other steps that use `transformationPath` are not given an extension. The separate type-id mismatch in #4106 is not changed here. `./mvnw -pl plugins/misc/import test -Dtest=KettleImport*Test -Dsurefire.failIfNoSpecifiedTests=false` completed with 52 tests, 0 failures, including `KettleImportKafkaConsumerTest`. A live import of a Kettle project was not run. fixes #4107 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
