mattcasters opened a new pull request, #8693:
URL: https://github.com/apache/hop/pull/8693

   Call DB Procedure closed every JDBC result set after the call, and the 
manual said those rows could not be retrieved. Drivers expose the first result 
set on the callable statement, and Table Input can already run the same call as 
SQL.
   
   Result type Row now writes one output row for each row of the procedure's 
first result set. The scalar function return is not registered in that mode. 
The columns from the Fields tab are matched by label or name, and OUT 
parameters are copied onto every result row. An empty result set produces no 
output row for that input. Later results are still drained so procedure errors 
surface. The dialog is split into General, Parameters, and Fields tabs. Fields 
is enabled only when the result type is Row, and Get fields reads statement 
metadata or executes the call and rolls back when the driver allows it.
   
   The Table Input page documents `CALL`, a PostgreSQL `SELECT`, and the JDBC 
call escape. The Call DB Procedure page describes the tabs and removes the old 
JDBC limitation.
   
   `tools/with-isolated-display.sh ./mvnw -pl core,plugins/transforms/dbproc 
-am test -Dtest=DatabaseTest,DBProcMetaTest 
-Dsurefire.failIfNoSpecifiedTests=false` passed: DatabaseTest 53 tests, 
DBProcMetaTest 7 tests. No live database was used and Hop GUI was not started.
   
   fixes #4858
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
   - [x] If you have a group of commits related to the same change, please 
squash your commits into one and force push your branch using `git rebase -i`.
   - [x] Mention the appropriate issue in your description (for example: 
`addresses #123`), if applicable.
   
   To make clear that you license your contribution under the [Apache License 
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to