mattcasters opened a new pull request, #8702: URL: https://github.com/apache/hop/pull/8702
Search in Hop GUI only covered the project that is currently open. The project menu had no entry for searching every configured project, and neither the search dialog nor the results panel showed which location was being searched. Project → Search projects..., placed under Edit project..., opens Search Everywhere with All projects selected. That location loads each configured project on its own variables and metadata provider, without enabling the project or replacing the GUI metadata and VFS providers. It includes pipelines, workflows, metadata, and the configuration files of every environment. A project that cannot be loaded is skipped. All projects stays out of the default combined search, so CTRL-F and All loaded locations still cover open files and the active project only. The footer of the search dialog and of the results panel has a location selector at the bottom right, next to the status text. Show all results keeps the location chosen in the popup. Opening a hit still uses the existing searchable callback and does not switch the active project. Unit tests passed under an isolated display: `tools/with-isolated-display.sh ./mvnw -pl core,ui,plugins/misc/projects -am test -Dtest=HopGuiSearchHelperTest,AllProjectsSearchablesLocationTest -Dsurefire.failIfNoSpecifiedTests=false` (HopGuiSearchHelperTest: 14 tests, AllProjectsSearchablesLocationTest: 3 tests, BUILD SUCCESS). The Hop GUI was not started, so the menu and footer widgets were not exercised interactively. fixes #6146 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
