bamaer commented on PR #8706: URL: https://github.com/apache/hop/pull/8706#issuecomment-5938203867
Thanks Matt, all five addressed: - **Follow system dark mode:** default documented as yes. - **Dark mode:** default now says off on Windows, follows the OS on macOS and other desktops. - **Enum defaults:** the generated cell now shows `External browser`. I didn't call `getLabel()` directly, though. The generator's classpath only has the plugin jars, and `BaseMessages` would pull in `HopConfig` and the builder's locale, so the output would vary between machines and trip the drift check. It reads `<Enum>.<NAME>` from the enum's en_US bundle instead, which is the same key `getLabel()` uses, and falls back to `name()`. - **configClass failures:** the build now fails with an `IllegalStateException` naming the class and plugin. - **Welcome dialog write:** added `theWelcomeDialogOptionIsStoredInverted`, which checks both polarities against an in-memory `HopConfig`. It fails with the `!` removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
